On Thu, Jun 09, 2011 at 06:42:41PM +0300, Dan Carpenter wrote: > On Thu, Jun 09, 2011 at 04:14:34PM +0300, Kalle Valo wrote: > > Dan Carpenter <error27@xxxxxxxxx> writes: > > > > >> --- a/drivers/staging/ath6kl/os/linux/ar6000_drv.c > > >> +++ b/drivers/staging/ath6kl/os/linux/ar6000_drv.c > > >> @@ -954,9 +954,13 @@ ar6000_transfer_bin_file(struct ar6_softc *ar, AR6K_BIN_FILE file, u32 address, > > >> const char *filename; > > >> const struct firmware *fw_entry; > > >> u32 fw_entry_size; > > >> + u8 **buf; > > >> + size_t *buf_len; > > > > > > Don't make buf_len a pointer that just makes the code messier. > > > > I need the pointer later so that I can store the length: > > > > *buf_len = fw_entry->size; > > No. The normal way to store an int is to do it like this: > > buf_len = fw_entry->size; I miss read what you were doing here. You code is correct here. I appologize for that. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
