Re: [PATCH 44/83] staging: brcm80211: replaced typedef si_t with struct si_pub

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 05, 2011 at 12:23:25PM -0700, julie Sullivan wrote:
> >
> > #include <dngl_stats.h>
> >
> > #include <dhd.h>
> > #include <linux/ieee80211.h>
> > -typedef const struct si_pub si_t;
> > +
> > +struct si_pub;
> >
> > #include <dngl_stats.h>
> > #include <dhd.h>
> 
> Is there any reason why dngl_stats.h and dhd.h are included twice in wl_iw.c?

No, no good reason.  The double inclusion seems to have been aournd for quite a
while.  A few others got cleaned up, but this one got missed.

> (if not, maybe you corrected this in another patch, I couldn't get the
> series to apply cleanly so there was no easy way of checking. If so
> sorry for the noise)

Nope, not fixed yet.  We'll get it cleaned up in a subsequent patch.

- Henry


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux