On Thu, Jun 2, 2011 at 18:32, Arend van Spriel <arend@xxxxxxxxxxxx> wrote: > On 06/02/2011 02:08 AM, Julian Calaby wrote: >> >> On Wed, Jun 1, 2011 at 21:45, Roland Vossen<rvossen@xxxxxxxxxxxx> wrote: >>> >>> Code cleanup. Header files only used by the softmac were moved to the >>> brcmsmac dir, same approach for fullmac header files. >>> >>> Signed-off-by: Roland Vossen<rvossen@xxxxxxxxxxxx> >>> Reviewed-by: Arend van Spriel<arend@xxxxxxxxxxxx> >> >> Again, should there be some code changes associated with the header >> file move or am I missing something? > > Hi Julian, > > This change (and 38/83) move the include file from brcm80211/include to > brcmfmac or brcmsmac depending which driver is actually using it. So these > include files can still be found by the preprocessor and no other changes > are needed to make it compile. The remaining issue would be a style issue > replacing brackets by quotes. Roland is currently going over all c sources > to cleanup file inclusion and the style issue is part of that cleanup. Not > sure if this is kind of code change you were expecting. If not please give > some more hints ;-) I was expecting the header files to be included using a directive like: #include "includes/bcmotp.h" Not #include <bcmotp.h> as you've done it. I was unaware that you were using the c-flags setting in the Makefile to make that work. Under my assumption, I was expecting to see a number of changes like: -#include "includes/bcmotp.h" +#include "brcmsmac/bcmotp.h" But now that I have seen the actual code in one of the later patches, I understand what you're doing here. Sorry for the noise. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
