Re: [PATCH 35/83] staging: brcm80211: moved header files to more specific directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/02/2011 02:08 AM, Julian Calaby wrote:
On Wed, Jun 1, 2011 at 21:45, Roland Vossen<rvossen@xxxxxxxxxxxx>  wrote:
Code cleanup. Header files only used by the softmac were moved to the
brcmsmac dir, same approach for fullmac header files.

Signed-off-by: Roland Vossen<rvossen@xxxxxxxxxxxx>
Reviewed-by: Arend van Spriel<arend@xxxxxxxxxxxx>
Again, should there be some code changes associated with the header
file move or am I missing something?

Hi Julian,

This change (and 38/83) move the include file from brcm80211/include to brcmfmac or brcmsmac depending which driver is actually using it. So these include files can still be found by the preprocessor and no other changes are needed to make it compile. The remaining issue would be a style issue replacing brackets by quotes. Roland is currently going over all c sources to cleanup file inclusion and the style issue is part of that cleanup. Not sure if this is kind of code change you were expecting. If not please give some more hints ;-)

Gr. AvS

--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux