Re: [PATCH 04/32] staging: brcm80211: got rid of #ifdef __mips__ sections in hnddma.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13 May 2011 11:59, Arend van Spriel <arend@xxxxxxxxxxxx> wrote:
> From: Roland Vossen <rvossen@xxxxxxxxxxxx>
>
> Code cleanup. Broadcom MIPS chips in big endian mode have a memory window
> in which sdram contents is byte swapped. Code in hnddmac.c makes use of
> this window. Reworked code so the #ifdef __mips__ is moved from .c to
> .h file.

Shouldn't this be guarded with e.g. CONFIG_BCM63XX instead of
__mips__? Not every big endian mips is a broadcom ;-). I don't know if
there are further Broadcom ones, the only other I know is bcm47xx and
that one is little endian.

Regards
Jonas
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux