On Mon, Mar 01, 2021 at 06:07:25PM +0300, Dan Carpenter wrote: > On Mon, Mar 01, 2021 at 10:00:11PM +0700, Candy Febriyanto wrote: > > The use of sprintf with format string here means that there is a risk > > that the writes will go out of bounds, replace it with scnprintf. > > > > In one block of the translate_scan function sprintf is only called once > > (it's not being used to concatenate strings) so there is no need to keep > > the pointer "p", remove it. > > > > Signed-off-by: Candy Febriyanto <cfebriyanto@xxxxxxxxx> > > --- > > Looks good. TBH, v1 was also fine. I should have just acked it instead > of commenting... > > Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > regards, > dan carpenter > Thanks for the review! _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
