On Sat, Apr 16, 2011 at 12:45:41AM +0300, Zeev Tarantov wrote: > On Fri, Apr 15, 2011 at 05:21, Greg KH <greg@xxxxxxxxx> wrote: > > Why is this needed to be added to the kernel? What does it provide that > > users or other parts of the kernel needs? > > It is functionally a general data compression tool that trades off > compression ratio for speed. It is optimized for x86-64 and there > achieves compression at 250MB/sec and decompression at 500MB/sec > (YMMV*). This is a better mousetrap, that can and should replace LZO > in every place where the kernel currently uses LZO. Like where? Have you done so and found it really to be faster and smaller? If so, benchmarks and the numbers will be required for this to be accepted. You need to show a solid use case for why to switch to this code in order to have it accepted. > The original code has been used in production by Google since 2005 or > so. It is stable and secure. Unless I've ruined it somehow when > porting, of course. It might be stable in userspace, that doesn't mean much for within the kernel though, please realize this. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel