On Mon, Oct 26, 2020 at 09:34:53AM +0530, Deepak R Varma wrote: > > - dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p (acd = %p)\n", cur, cur->acd); > > + dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p (acd = %p)\n", > > + cur, > > + cur->acd); Why do you put 'cur' and 'cur->acd' on different lines? > > - rv = request_irq(eng->irq, ndd_irq_handler, IRQF_SHARED, KP_DRIVER_NAME_DMA_CONTROLLER, eng); > > + rv = request_irq(eng->irq, > > + ndd_irq_handler, > > + IRQF_SHARED, > > + KP_DRIVER_NAME_DMA_CONTROLLER, > > + eng); Likewise. I'd do: rv = request_irq(eng->irq, ndd_irq_handler, IRQF_SHARED, KP_DRIVER_NAME_DMA_CONTROLLER, eng); _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
