On Wed, Oct 21, 2020 at 01:05:25PM +0530, Deepak R Varma wrote:
Hello,
Requesting a review / ack for this patch.
Thank you,
Deepak.
> Rename show_engine_regs show function to engine_regs_show as per the
> convention followed. The show function macro DEVICE_ATTR is replaced
> by DEVICE_ATTR_RO. Issue reported by checkpatch script.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@xxxxxxxxx>
> ---
> Changes since v1:
> - Replace DEVICE_ATTR by DEVICE_ATTR_RO as suggested by Greg.
>
> drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
> index 7698e5ef2a7c..aa9f96793e59 100644
> --- a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
> +++ b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
> @@ -50,7 +50,7 @@ static void kpc_dma_del_device(struct kpc_dma_device *ldev)
> }
>
> /********** SysFS Attributes **********/
> -static ssize_t show_engine_regs(struct device *dev, struct device_attribute *attr, char *buf)
> +static ssize_t engine_regs_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> struct kpc_dma_device *ldev;
> struct platform_device *pldev = to_platform_device(dev);
> @@ -80,7 +80,7 @@ static ssize_t show_engine_regs(struct device *dev, struct device_attribute *at
> ldev->desc_completed
> );
> }
> -static DEVICE_ATTR(engine_regs, 0444, show_engine_regs, NULL);
> +static DEVICE_ATTR_RO(engine_regs);
>
> static const struct attribute *ndd_attr_list[] = {
> &dev_attr_engine_regs.attr,
> --
> 2.25.1
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
