On Mon, Oct 19, 2020 at 11:17:38AM +0100, Ian Abbott wrote: > On 18/10/2020 20:48, Deepak R Varma wrote: > > Boolean comparison of the condition inside unittest function is > > unnecessary and can be simplified by directly using the condition > > outcome for evaluation. Issue reported by : > > scripts/coccinelle/misc/boolinit.cocci > > > > Signed-off-by: Deepak R Varma <mh12gx2825@xxxxxxxxx> > > --- > > drivers/staging/comedi/drivers/tests/ni_routes_test.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/comedi/drivers/tests/ni_routes_test.c b/drivers/staging/comedi/drivers/tests/ni_routes_test.c > > index eaefaf596a37..7db83cf5e4aa 100644 > > --- a/drivers/staging/comedi/drivers/tests/ni_routes_test.c > > +++ b/drivers/staging/comedi/drivers/tests/ni_routes_test.c > > @@ -499,13 +499,13 @@ void test_route_register_is_valid(void) > > const struct ni_route_tables *T = &private.routing_tables; > > init_pci_fake(); > > - unittest(route_register_is_valid(4, O(4), T) == false, > > + unittest(!route_register_is_valid(4, O(4), T), > > "check for bad source 4-->4\n"); > > - unittest(route_register_is_valid(0, O(1), T) == true, > > + unittest(!route_register_is_valid(0, O(1), T), > > "find first source\n"); > > - unittest(route_register_is_valid(4, O(6), T) == true, > > + unittest(!route_register_is_valid(4, O(6), T), > > "find middle source\n"); > > - unittest(route_register_is_valid(9, O(8), T) == true, > > + unittest(!route_register_is_valid(9, O(8), T), > > "find last source"); > > } > > NAK. > > It looks like you have inadvertently inverted some of the tests. Hi Ian, Thank you for catching that. I am correcting it and will send a v2 shortly. Deepak. > > -- > -=( Ian Abbott <abbotti@xxxxxxxxx> || MEV Ltd. is a company )=- > -=( registered in England & Wales. Regd. number: 02862268. )=- > -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- > -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
