On Thu, Apr 07, 2011 at 11:20:58AM +0200, Roland Vossen wrote: > Driver modules from the staging directory are marked 'tainted' > by module.c. Subsequently, tainted modules are denied dynamic > debugging. This is unwanted behavior, since staging modules should > be able to use the dynamic debugging mechanism. > > Please merge this also into the staging-linus branch. > > Signed-off-by: Roland Vossen <rvossen@xxxxxxxxxxxx> > --- > kernel/module.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/module.c b/kernel/module.c > index 1f9f7bc..71983f2 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -2790,7 +2790,7 @@ static struct module *load_module(void __user *umod, > } > > /* This has to be done once we're sure module name is unique. */ > - if (!mod->taints) > + if (!mod->taints || mod->taints == (1U<<TAINT_CRAP)) > dynamic_debug_setup(info.debug, info.num_debug); > > /* Find duplicate symbols */ > @@ -2827,7 +2827,7 @@ static struct module *load_module(void __user *umod, > module_bug_cleanup(mod); > > ddebug: > - if (!mod->taints) > + if (!mod->taints || mod->taints == (1U<<TAINT_CRAP)) > dynamic_debug_remove(info.debug); > unlock: > mutex_unlock(&module_mutex); > -- > 1.7.1 > > Looks good to me. Please add my ack. Acked-by: Jason Baron <jbaron@xxxxxxxxxx> thanks, -Jason _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
