Hello Dan,
On 09/10/2020 14:24, Dan Carpenter wrote:
> On Fri, Oct 09, 2020 at 11:46:05AM +0200, Alexander A Sverdlin wrote:
>> --- a/drivers/staging/octeon/ethernet-rx.c
>> +++ b/drivers/staging/octeon/ethernet-rx.c
>> @@ -69,14 +69,16 @@ static inline int cvm_oct_check_rcv_error(struct cvmx_wqe *work)
>> else
>> port = work->word1.cn38xx.ipprt;
>>
>> - if ((work->word2.snoip.err_code == 10) && (work->word1.len <= 64)) {
>> + if ((work->word2.snoip.err_code == 10) && (work->word1.len <= 64))
>> /*
>> * Ignore length errors on min size packets. Some
>> * equipment incorrectly pads packets to 64+4FCS
>> * instead of 60+4FCS. Note these packets still get
>> * counted as frame errors.
>> */
>> - } else if (work->word2.snoip.err_code == 5 ||
>> + return 0;
>> +
>> + if (work->word2.snoip.err_code == 5 ||
>> work->word2.snoip.err_code == 7) {
> This line is indented to match the old code and it no longer matches.
> (Please update the whitespace).
thanks to your comment I took a fresh look onto the patch and found a logic error
in the change. Please ignore the whole patch for now.
>> /*
>> * We received a packet with either an alignment error
--
Best regards,
Alexander Sverdlin.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
