Hi Dan,
I can't review the code right now because someone stole my laptop yesterday
That sucks significantly.
The code has been improved a lot.
Good to hear.
One thing which should probably be in the TODO list is replacing broadcom error codes with standard error codes. BRD_NOMEM => ENOMEM or whatever. These are defined in the util.h file.
Thanks, I added this one to our task list.
I also don't like the WL_ERROR macro.
Me neither. I am in the process of removing it. Expect a patch on the short term.
I don't like the W_REG() and R_REG() macros much either. The caller should state explicitly if the are reading a byte, short or int something like brd_readb(). It should be a function so it has type checking. The current code is just guessing based on the type of variable... It's asking for bugs.
Also added this to our task list.
The TODO file talks about implementing other features. I don't have a say in this but I don't think that's needed to get moved out of staging.
A while ago, I submitted an updated TODO but Greg has not merged that one yet (I guess he is busy with the 2.6.38 -> 2.6.39 transition). That updated TODO does not contain new features anymore.
Thanks very much for your feedback, Roland Vossen. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
