On Sat, 2020-06-27 at 10:18 +0200, Greg KH wrote: > On Sat, Jun 27, 2020 at 01:12:42AM -0700, Joe Perches wrote: > > On Sat, 2020-06-27 at 10:01 +0200, Greg KH wrote: > > > On Sat, Jun 27, 2020 at 12:33:56AM -0700, Joe Perches wrote: > > > > There are 3 parts of the email. > > > > > > > > 1: A description and patch for a logging defect > > > > 2: A script to go along with the patch to do conversions > > > > 3: Current diff for this defect > > > > > > > > ------------------------------------------------------------------------ > > > > - > > > > > > > > The macro below in drivers/staging/rtl8188eu/include/rtw_debug.h > > > > is defective as it emits multiple pr_info calls for each use > > > > so the logging in dmesg is discontinuous. > > > > > > I recommend just deleting it. As it's obviously incorrect, and any > > > "real" tracing should just use the real tracing infrastructure, this is > > > not needed and can be removed. > > > > Don't get hung up on the name. > > > > It's not used for tracing, it's effectively just > > a debugging mechanism, the same in all the other > > rtl staging drivers. > > Ok, then it should be converted to "normal" dev_*() functions, where > needed, the others deleted entirely (the dev_info attempts...) Nope. These are the same as uses in drivers/net/wireless/realtek/rtlwifi. $ git grep -w RT_TRACE drivers/net/wireless/realtek | wc -l 2847 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
