Re: RT_TRACE in drivers/staging/rtl8188eu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2020-06-27 at 10:01 +0200, Greg KH wrote:
> On Sat, Jun 27, 2020 at 12:33:56AM -0700, Joe Perches wrote:
> > There are 3 parts of the email.
> > 
> > 1: A description and patch for a logging defect
> > 2: A script to go along with the patch to do conversions
> > 3: Current diff for this defect
> > 
> > ------------------------------------------------------------------------
> > -
> > 
> > The macro below in drivers/staging/rtl8188eu/include/rtw_debug.h
> > is defective as it emits multiple pr_info calls for each use
> > so the logging in dmesg is discontinuous.
> 
> I recommend just deleting it.  As it's obviously incorrect, and any
> "real" tracing should just use the real tracing infrastructure, this is
> not needed and can be removed.

Don't get hung up on the name.

It's not used for tracing, it's effectively just
a debugging mechanism, the same in all the other
rtl staging drivers.



_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux