Re: [PATCH 2/2] staging: brcm80211: replace asserts close to Mac80211 interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 29, 2011 at 02:03:36PM +0200, Roland Vossen wrote:
> The reason that I am investing time in the ASSERT/WARN_ON etc
> patches is that Greg KH does not want ASSERT statement in our
> driver. It would be great if I could simply replace all ASSERTs with
> WARN_ONs (inversing the condition checked of course), so I can focus
> on improving code readability.

That doesn't make sense, why replace them all with warnings?  Why would
those thing ever need an assert in the first place?  Please rework the
code to never need them, or, if they are a real case, then properly
handle them without a warning being sent to the user who really has no
idea how to handle them.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux