On Tue, 2019-11-05 at 16:50 +0100, Greg KH wrote: > On Tue, Nov 05, 2019 at 10:36:59PM +0800, Chen Wandun wrote: > > From: Chenwandun <chenwandun@xxxxxxxxxx> > > > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/staging/hp/hp100.c: In function hp100_start_xmit: > > drivers/staging/hp/hp100.c:1629:10: warning: variable val set but not used [-Wunused-but-set-variable] > > > > Signed-off-by: Chenwandun <chenwandun@xxxxxxxxxx> > > I need a "full" name here, like the one on your email "From:" line. You also need the submitter to run checkpatch on the patch and not just the file. WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please. WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please. total: 0 errors, 2 warnings, 0 checks, 18 lines checked > > diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c [] > > @@ -1626,7 +1626,9 @@ static netdev_tx_t hp100_start_xmit(struct sk_buff *skb, > > unsigned long flags; > > int i, ok_flag; > > int ioaddr = dev->base_addr; > > +#ifdef HP100_DEBUG_TX > > u_short val; > > +#endif > > #ifdefs are not ok in .c code, sorry. > > > struct hp100_private *lp = netdev_priv(dev); > > > > #ifdef HP100_DEBUG_B > > @@ -1695,7 +1697,9 @@ static netdev_tx_t hp100_start_xmit(struct sk_buff *skb, > > > > spin_lock_irqsave(&lp->lock, flags); > > hp100_ints_off(); > > +#ifdef HP100_DEBUG_TX > > val = hp100_inw(IRQ_STATUS); > > Are you sure that this doesn't actually change the hardware in some way? If anyone still _has_ the hardware, please let me know. I have the only VG test equipment I know of in a box somewhere in my basement and it's yours for the asking and the postage. It hasn't been powered on in 25 years, no guarantees... _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
