On Tue, Nov 05, 2019 at 10:36:59PM +0800, Chen Wandun wrote: > From: Chenwandun <chenwandun@xxxxxxxxxx> > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/staging/hp/hp100.c: In function hp100_start_xmit: > drivers/staging/hp/hp100.c:1629:10: warning: variable val set but not used [-Wunused-but-set-variable] > > Signed-off-by: Chenwandun <chenwandun@xxxxxxxxxx> I need a "full" name here, like the one on your email "From:" line. > --- > drivers/staging/hp/hp100.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c > index 6ec78f5..6fc7733 100644 > --- a/drivers/staging/hp/hp100.c > +++ b/drivers/staging/hp/hp100.c > @@ -1626,7 +1626,9 @@ static netdev_tx_t hp100_start_xmit(struct sk_buff *skb, > unsigned long flags; > int i, ok_flag; > int ioaddr = dev->base_addr; > +#ifdef HP100_DEBUG_TX > u_short val; > +#endif #ifdefs are not ok in .c code, sorry. > struct hp100_private *lp = netdev_priv(dev); > > #ifdef HP100_DEBUG_B > @@ -1695,7 +1697,9 @@ static netdev_tx_t hp100_start_xmit(struct sk_buff *skb, > > spin_lock_irqsave(&lp->lock, flags); > hp100_ints_off(); > +#ifdef HP100_DEBUG_TX > val = hp100_inw(IRQ_STATUS); Are you sure that this doesn't actually change the hardware in some way? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
