Re: [PATCH v2 1/2] staging: rtl8192u: Add or remove spaces to fix style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 26, 2019 at 11:39:09PM +0530, Sumera Priyadarsini wrote:
> This patch fixes the file r8190_rtl8256.c to avoid the following
> checkpatch.pl warnings:
> 	CHECK: spaces preferred around that '<<' (ctx:VxV)
> 	CHECK: spaces preferred around that '-' (ctx:VxV)
> 	CHECK: No space is necessary after a cast
> 
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@xxxxxxxxx>
> ---
> Changes since v1:
> - Split the commit into two patches
> ---
>  drivers/staging/rtl8192u/r8190_rtl8256.c | 30 ++++++++++++------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
> index 0bedf88525cd..7c7f8247b27a 100644
> --- a/drivers/staging/rtl8192u/r8190_rtl8256.c
> +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
> @@ -42,9 +42,9 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum ht_channel_width Band
>  
>  		switch (Bandwidth) {
>  		case HT_CHANNEL_WIDTH_20:
> -				if (priv->card_8192_version == VERSION_819XU_A
> -					|| priv->card_8192_version
> -					== VERSION_819XU_B) { /* 8256 D-cut, E-cut, xiong: consider it later! */
> +				if (priv->card_8192_version == VERSION_819XU_A ||
> +					priv->card_8192_version ==
> +					VERSION_819XU_B) { /* 8256 D-cut, E-cut, xiong: consider it later! */

These lines are indented too far and the == should go on the first line
like the || does.

			if (priv->card_8192_version == VERSION_819XU_A ||
			    priv->card_8192_version == VERSION_819XU_B) {
				/* 8256 D-cut, E-cut, xiong: consider it later! */

Probably do this in a separate patch.  It's sort of not really related
to the other changes.

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux