On 7/16/19 1:36 AM, Greg Kroah-Hartman wrote: > On Mon, Jul 15, 2019 at 02:21:23PM -0700, john.hubbard@xxxxxxxxx wrote: >> From: John Hubbard <jhubbard@xxxxxxxxxx> ... >> drivers/staging/kpc2000/kpc2000_i2c.c | 189 +++++++++++------ >> drivers/staging/kpc2000/kpc2000_spi.c | 116 +++++----- >> drivers/staging/kpc2000/kpc_dma/dma.c | 109 ++++++---- >> drivers/staging/kpc2000/kpc_dma/fileops.c | 199 +++++++++++------- >> .../staging/kpc2000/kpc_dma/kpc_dma_driver.c | 113 +++++----- >> .../staging/kpc2000/kpc_dma/kpc_dma_driver.h | 156 +++++++------- >> 6 files changed, 509 insertions(+), 373 deletions(-) > > THat's way too many different types of changes to do all at once, and > some of these are making the code look worse, not better. > > There's a reason we don't run lindent :) Yes, I am seeing that very clearly now. :) > > If you want to do one-type-of-fix-per-patch, I'll gladly take these, > otherwise, I recommend leaving this for those people learning how to do > development to do. > OK, I'm going to pretend that I'm not one of those people, despite recent hard evidence to the contrary here. haha. Anyway, this does present a nice set of things for new developers to get started on. So I'll leave it as is. thanks, -- John Hubbard NVIDIA _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
