On Mon, Jul 15, 2019 at 02:21:23PM -0700, john.hubbard@xxxxxxxxx wrote: > From: John Hubbard <jhubbard@xxxxxxxxxx> > > This commit was created by running indent(1): > `indent -linux` > > ...and then applying some manual corrections and > cleanup afterward, to keep it sane. No functional changes > were made. > > In addition to whitespace changes, some strings were split, > but not strings that were likely to be a grep problem > (in other words, if a user is likely to grep for a string > within the driver, that should still work in most cases). > > A few "void * foo" cases were fixed to be "void *foo". > > That was enough to make checkpatch.pl run without errors, > although note that there are lots of serious warnings > remaining--but those require functional, not just whitespace > changes. So those are left for a separate patch. > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Simon Sandström <simon@xxxxxxxxxx> > Cc: Geordan Neukum <gneukum1@xxxxxxxxx> > Cc: Jeremy Sowden <jeremy@xxxxxxxxxx> > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Cc: Vandana BN <bnvandana@xxxxxxxxx> > Cc: devel@xxxxxxxxxxxxxxxxxxxx > Cc: Bharath Vedartham <linux.bhar@xxxxxxxxx> > Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx> > --- > drivers/staging/kpc2000/kpc2000_i2c.c | 189 +++++++++++------ > drivers/staging/kpc2000/kpc2000_spi.c | 116 +++++----- > drivers/staging/kpc2000/kpc_dma/dma.c | 109 ++++++---- > drivers/staging/kpc2000/kpc_dma/fileops.c | 199 +++++++++++------- > .../staging/kpc2000/kpc_dma/kpc_dma_driver.c | 113 +++++----- > .../staging/kpc2000/kpc_dma/kpc_dma_driver.h | 156 +++++++------- > 6 files changed, 509 insertions(+), 373 deletions(-) THat's way too many different types of changes to do all at once, and some of these are making the code look worse, not better. There's a reason we don't run lindent :) If you want to do one-type-of-fix-per-patch, I'll gladly take these, otherwise, I recommend leaving this for those people learning how to do development to do. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
