Hi Yue, On 2019/6/26 11:30, Yue Hu wrote: > From: Yue Hu <huyue2@xxxxxxxxxx> > > We should consider the error returned by fill_inline_data() when filling > last page in fill_inode(). If not getting inode will be successful even > though last page is bad. That is illogical. Also change -EAGAIN to 0 in > fill_inline_data() to stand for successful filling. > > Signed-off-by: Yue Hu <huyue2@xxxxxxxxxx> ditto, add the tags from other guyes. Thanks, Gao Xiang > --- > drivers/staging/erofs/inode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c > index d6e1e16..1433f25 100644 > --- a/drivers/staging/erofs/inode.c > +++ b/drivers/staging/erofs/inode.c > @@ -156,7 +156,7 @@ static int fill_inline_data(struct inode *inode, void *data, > inode->i_link = lnk; > set_inode_fast_symlink(inode); > } > - return -EAGAIN; > + return 0; > } > > static int fill_inode(struct inode *inode, int isdir) > @@ -223,7 +223,7 @@ static int fill_inode(struct inode *inode, int isdir) > inode->i_mapping->a_ops = &erofs_raw_access_aops; > > /* fill last page if inline data is available */ > - fill_inline_data(inode, data, ofs); > + err = fill_inline_data(inode, data, ofs); > } > > out_unlock: > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
