Re: [PATCH] staging: wlan-ng: Shorten excessively long p80211 constants

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mikhail,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.1-rc2 next-20190329]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mikhail-Gusarov/staging-wlan-ng-Shorten-excessively-long-p80211-constants/20190329-151335
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

   In file included from drivers/staging/wlan-ng/prism2usb.c:4:
>> drivers/staging/wlan-ng/prism2mib.c:176:3: error: 'SMT_PRIVTABLE_EXCLUDEUNENCRYPTED' undeclared here (not in a function); did you mean 'SMT_PRIVTABLE_EXUNENCRYPTED'?
     {SMT_PRIVTABLE_EXCLUDEUNENCRYPTED,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      SMT_PRIVTABLE_EXUNENCRYPTED
--
   drivers/staging/wlan-ng/p80211req.c: In function 'p80211req_mibset_mibget':
>> drivers/staging/wlan-ng/p80211req.c:236:7: error: 'SMT_PRIVTABLE_EXCLUDEUNENCRYPTED' undeclared (first use in this function); did you mean 'SMT_PRIVTABLE_EXUNENCRYPTED'?
     case SMT_PRIVTABLE_EXCLUDEUNENCRYPTED: {
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          SMT_PRIVTABLE_EXUNENCRYPTED
   drivers/staging/wlan-ng/p80211req.c:236:7: note: each undeclared identifier is reported only once for each function it appears in

vim +176 drivers/staging/wlan-ng/prism2mib.c

    95	
    96	static int prism2mib_bytearea2pstr(struct mibrec *mib,
    97					   int isget,
    98					   struct wlandevice *wlandev,
    99					   struct hfa384x *hw,
   100					   struct p80211msg_dot11req_mibset *msg,
   101					   void *data);
   102	
   103	static int prism2mib_uint32(struct mibrec *mib,
   104				    int isget,
   105				    struct wlandevice *wlandev,
   106				    struct hfa384x *hw,
   107				    struct p80211msg_dot11req_mibset *msg, void *data);
   108	
   109	static int prism2mib_flag(struct mibrec *mib,
   110				  int isget,
   111				  struct wlandevice *wlandev,
   112				  struct hfa384x *hw,
   113				  struct p80211msg_dot11req_mibset *msg, void *data);
   114	
   115	static int prism2mib_wepdefaultkey(struct mibrec *mib,
   116					   int isget,
   117					   struct wlandevice *wlandev,
   118					   struct hfa384x *hw,
   119					   struct p80211msg_dot11req_mibset *msg,
   120					   void *data);
   121	
   122	static int prism2mib_privacyinvoked(struct mibrec *mib,
   123					    int isget,
   124					    struct wlandevice *wlandev,
   125					    struct hfa384x *hw,
   126					    struct p80211msg_dot11req_mibset *msg,
   127					    void *data);
   128	
   129	static int prism2mib_excludeunencrypted(struct mibrec *mib,
   130						int isget,
   131						struct wlandevice *wlandev,
   132						struct hfa384x *hw,
   133						struct p80211msg_dot11req_mibset *msg,
   134						void *data);
   135	
   136	static int
   137	prism2mib_fragmentationthreshold(struct mibrec *mib,
   138					 int isget,
   139					 struct wlandevice *wlandev,
   140					 struct hfa384x *hw,
   141					 struct p80211msg_dot11req_mibset *msg,
   142					 void *data);
   143	
   144	static int prism2mib_priv(struct mibrec *mib,
   145				  int isget,
   146				  struct wlandevice *wlandev,
   147				  struct hfa384x *hw,
   148				  struct p80211msg_dot11req_mibset *msg, void *data);
   149	
   150	static struct mibrec mibtab[] = {
   151		/* dot11smt MIB's */
   152		{smt_wepdefaultkeystable_key(1),
   153		 F_STA | F_WRITE,
   154		 HFA384x_RID_CNFWEPDEFAULTKEY0, 0, 0,
   155		 prism2mib_wepdefaultkey},
   156		{smt_wepdefaultkeystable_key(2),
   157		 F_STA | F_WRITE,
   158		 HFA384x_RID_CNFWEPDEFAULTKEY1, 0, 0,
   159		 prism2mib_wepdefaultkey},
   160		{smt_wepdefaultkeystable_key(3),
   161		 F_STA | F_WRITE,
   162		 HFA384x_RID_CNFWEPDEFAULTKEY2, 0, 0,
   163		 prism2mib_wepdefaultkey},
   164		{smt_wepdefaultkeystable_key(4),
   165		 F_STA | F_WRITE,
   166		 HFA384x_RID_CNFWEPDEFAULTKEY3, 0, 0,
   167		 prism2mib_wepdefaultkey},
   168		{SMT_PRIVTABLE_PRIVACYINVOKED,
   169		 F_STA | F_READ | F_WRITE,
   170		 HFA384x_RID_CNFWEPFLAGS, HFA384x_WEPFLAGS_PRIVINVOKED, 0,
   171		 prism2mib_privacyinvoked},
   172		{SMT_PRIVTABLE_WEPDEFAULTKEYID,
   173		 F_STA | F_READ | F_WRITE,
   174		 HFA384x_RID_CNFWEPDEFAULTKEYID, 0, 0,
   175		 prism2mib_uint32},
 > 176		{SMT_PRIVTABLE_EXCLUDEUNENCRYPTED,
   177		 F_STA | F_READ | F_WRITE,
   178		 HFA384x_RID_CNFWEPFLAGS, HFA384x_WEPFLAGS_EXCLUDE, 0,
   179		 prism2mib_excludeunencrypted},
   180	
   181		/* dot11mac MIB's */
   182	
   183		{MAC_OPTABLE_MACADDRESS,
   184		 F_STA | F_READ | F_WRITE,
   185		 HFA384x_RID_CNFOWNMACADDR, HFA384x_RID_CNFOWNMACADDR_LEN, 0,
   186		 prism2mib_bytearea2pstr},
   187		{MAC_OPTABLE_RTSTHRESHOLD,
   188		 F_STA | F_READ | F_WRITE,
   189		 HFA384x_RID_RTSTHRESH, 0, 0,
   190		 prism2mib_uint32},
   191		{MAC_OPTABLE_SHORTRETRYLIMIT,
   192		 F_STA | F_READ,
   193		 HFA384x_RID_SHORTRETRYLIMIT, 0, 0,
   194		 prism2mib_uint32},
   195		{MAC_OPTABLE_LONGRETRYLIMIT,
   196		 F_STA | F_READ,
   197		 HFA384x_RID_LONGRETRYLIMIT, 0, 0,
   198		 prism2mib_uint32},
   199		{MAC_OPTABLE_FRAGTHRESHOLD,
   200		 F_STA | F_READ | F_WRITE,
   201		 HFA384x_RID_FRAGTHRESH, 0, 0,
   202		 prism2mib_fragmentationthreshold},
   203		{MAC_OPTABLE_MAXTXMSDULIFETIME,
   204		 F_STA | F_READ,
   205		 HFA384x_RID_MAXTXLIFETIME, 0, 0,
   206		 prism2mib_uint32},
   207	
   208		/* dot11phy MIB's */
   209	
   210		{PHY_DSSSTABLE_CURRCHAN,
   211		 F_STA | F_READ,
   212		 HFA384x_RID_CURRENTCHANNEL, 0, 0,
   213		 prism2mib_uint32},
   214		{PHY_TXPOWERTABLE_CURRTXPOWERLEVEL,
   215		 F_STA | F_READ | F_WRITE,
   216		 HFA384x_RID_TXPOWERMAX, 0, 0,
   217		 prism2mib_uint32},
   218	
   219		/* p2Static MIB's */
   220	
   221		{P2_STATIC_CNFPORTTYPE,
   222		 F_STA | F_READ | F_WRITE,
   223		 HFA384x_RID_CNFPORTTYPE, 0, 0,
   224		 prism2mib_uint32},
   225	
   226		/* p2MAC MIB's */
   227	
   228		{P2_MAC_CURRTXRATE,
   229		 F_STA | F_READ,
   230		 HFA384x_RID_CURRENTTXRATE, 0, 0,
   231		 prism2mib_uint32},
   232	
   233		/* And finally, lnx mibs */
   234		{LNX_CONFIGTABLE_RSNAIE,
   235		 F_STA | F_READ | F_WRITE,
   236		 HFA384x_RID_CNFWPADATA, 0, 0,
   237		 prism2mib_priv},
   238		{0, 0, 0, 0, 0, NULL}
   239	};
   240	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux