On Fri, Mar 29, 2019 at 06:25:09AM +0000, Mikhail Gusarov wrote: > drivers/staging/wlan-ng/p80211metadef.h was generated before > submitting to Linux, so it contains long constants and > ugly code. > > - Shorten macro names for DIDMSG_*/DIDMIB_* constants generators > - Drop repeating prefixes from DIDMSG_*/DIDMIB_* constants > - Use abbreviations where spelling full words is unnecessary > (OPERATIONTABLE -> OPTABLE, TRANSMISSION->TX etc) That is a lot of different things all to be doing at once. Please break thsi up into a series of individual patches, each only doing one logical thing at a time. > > No functional changes. > > Signed-off-by: Mikhail Gusarov <dottedmag@xxxxxxxxxxxxx> > --- > drivers/staging/wlan-ng/cfg80211.c | 48 +++--- > drivers/staging/wlan-ng/p80211metadef.h | 278 +++++++++----------------------- > drivers/staging/wlan-ng/p80211netdev.c | 8 +- > drivers/staging/wlan-ng/p80211req.c | 28 ++-- > drivers/staging/wlan-ng/p80211types.h | 32 +--- > drivers/staging/wlan-ng/prism2fw.c | 32 ++-- > drivers/staging/wlan-ng/prism2mib.c | 40 ++--- > drivers/staging/wlan-ng/prism2sta.c | 34 ++-- > 8 files changed, 182 insertions(+), 318 deletions(-) What changed from v1? That always needs to go below the --- line as is documented. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
