On 2019/2/15 15:36, Dan Carpenter wrote: > On Fri, Feb 15, 2019 at 10:10:34AM +0800, Chao Yu wrote: >> Hi Dan, >> >> Any suggestion? >> > > I won't NAK whatever you decide. But my opinion is that you should > just use normal kernel memory allocators even though it means you have > to use two different fault injection frameworks. Thanks for the suggestion. There is only one injection type in erofs injection framework, I don't want to remove all framework codes with kmalloc type, so I think we can do this step by step: a. use erofs_kamloc to keep all codes consistent. b. add at least one erofs private injection type. c. remove erofs_kmalloc and related type. > > Over time it would be good to improve and expand the standard kernel > error injection frameworks to cover more types. Agreed. Thanks, > > regards, > dan carpenter > > > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel