Re: rtl8192e: need help with variable naming convention

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 14, 2019 at 05:39:24PM +0530, Himadri Pandya wrote:
> On Mon, 14 Jan, 2019, 4:21 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx wrote:
> 
> Naming is hard.  Having "_array" in the name isn't great either.  It's
> > normally obvious it's an array because of the [] characters.
> >
> 
> Okay. How about renaming it to "_list[ ]" ? But I'm not sure if calling it
> a list will introduce redundancy or increase readability by showing we're
> implementing a list with an array?

_list is fine.  Or _array is fine, really.  Even channal_plan[] seems
Ok to me.  Something that mentions region, perhaps?  It's all fine.

So long as you're thinking about naming and trying to say something
then it's probably fine.  We're not trying to be ogres or to reject
patches.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux