Re: rtl8192e: need help with variable naming convention

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 07, 2019 at 04:04:46PM +0530, Himadri Pandya wrote:
> Hello,
> 
> I'm getting started with device drivers. And as a starter, I'm working on
> some clean-up patches.  I'm particularly targeting to rename a structure
> array "ChannelPlan"(in file dot11d.c) to fix a checkpatch.pl warning "Avoid
> CamelCase". According to the coding style, it should be converted to
> "channel_plan". But the code contains a function argument with the same
> name "channel_plan". Should I then rename the array to something like
> "channel_name_"? I'm sorry for asking such a silly question. But I want to
> know if renaming it in such a ways fits in the convention before I make the
> change.

A structure name is different from a function name, so odds are you can
just do this with no problems.  Try it and find out!

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux