On Thu, Jan 10, 2019 at 06:13:47AM +0000, Sidong Yang wrote:
> Removed unnecessary local variable in have_hgsmi_mode_hints.
> The result of hgsmi_query_conf should be directly compared without
> assigning to local variable.
>
> Signed-off-by: Sidong Yang <realwakka@xxxxxxxxx>
> ---
> drivers/staging/vboxvideo/vbox_main.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
> index e1fb70a42d32..62a69fde7435 100644
> --- a/drivers/staging/vboxvideo/vbox_main.c
> +++ b/drivers/staging/vboxvideo/vbox_main.c
> @@ -170,18 +170,15 @@ static void vbox_accel_fini(struct vbox_private *vbox)
> static bool have_hgsmi_mode_hints(struct vbox_private *vbox)
> {
> u32 have_hints, have_cursor;
> - int ret;
>
> - ret = hgsmi_query_conf(vbox->guest_pool,
> - VBOX_VBVA_CONF32_MODE_HINT_REPORTING,
> - &have_hints);
> - if (ret)
> + if (hgsmi_query_conf(vbox->guest_pool,
> + VBOX_VBVA_CONF32_MODE_HINT_REPORTING,
> + &have_hints))
> return false;
As Dan says, the original is best here. I'm dropping this from my patch
queue.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
