On Thu, Jan 10, 2019 at 12:39 AM Greg KH <greg@xxxxxxxxx> wrote:
>
> On Thu, Jan 10, 2019 at 12:26:28AM -0700, thirtythreeforty@xxxxxxxxx wrote:
> > From: George Hilliard <thirtythreeforty@xxxxxxxxx>
> >
> > These drivers are useful on other MT76xx SoCs, which have compatible
> > peripherals. The drivers are selectable in Kconfig, but they were
> > quietly excluded from the build because the SOC_MT7621 chip was not
> > selected. So, make the main staging Makefile use the same flags as
> > everything else for these drivers.
> >
> > I have personally confirmed that the mt7621-spi driver works on the
> > MT7688, which was what prompted this change.
> >
> > Cc: devel@xxxxxxxxxxxxxxxxxxxx
> > Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> > Cc: John Crispin <blogic@xxxxxxxxxxx>
> > Signed-off-by: George Hilliard <thirtythreeforty@xxxxxxxxx>
> > ---
> > drivers/staging/Makefile | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> > index 5868631e8f1b..50c980c16c0d 100644
> > --- a/drivers/staging/Makefile
> > +++ b/drivers/staging/Makefile
> > @@ -42,10 +42,10 @@ obj-$(CONFIG_BCM2835_VCHIQ) += vc04_services/
> > obj-$(CONFIG_DRM_VBOXVIDEO) += vboxvideo/
> > obj-$(CONFIG_PI433) += pi433/
> > obj-$(CONFIG_SOC_MT7621) += mt7621-pci/
> > -obj-$(CONFIG_SOC_MT7621) += mt7621-pinctrl/
> > -obj-$(CONFIG_SOC_MT7621) += mt7621-spi/
> > +obj-$(CONFIG_PINCTRL_RT2880) += mt7621-pinctrl/
> > +obj-$(CONFIG_SPI_MT7621) += mt7621-spi/
> > obj-$(CONFIG_SOC_MT7621) += mt7621-dma/
>
> What about the DMA driver?
It has two separate drivers in it, actually. Briefly:
config DMA_RALINK
tristate "RALINK DMA support"
depends on RALINK && !SOC_RT288X
config MTK_HSDMA
tristate "MTK HSDMA support"
depends on RALINK && SOC_MT7621
I think they should be broken out into two separate directories to
make them amenable to this change. Should I do this?
>
> > -obj-$(CONFIG_SOC_MT7621) += mt7621-mmc/
> > +obj-$(CONFIG_MTK_MMC) += mt7621-mmc/
> > obj-$(CONFIG_SOC_MT7621) += mt7621-eth/
> > obj-$(CONFIG_SOC_MT7621) += mt7621-dts/
>
> And these drivers? Why not change all of these at once?
mt7621-dts ignored because it truly does depend on the MT7621 (only
thing in there is the device tree for the GnuBee).
mt7621-eth ignored because I forgot it. I'll add to the next revision.
>
> thanks,
>
> greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
