Re: [PATCH v2 1/3] staging: mt7621-pci-phy: add new driver for phy part of mt7621-pci

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 24 2018, Sergio Paracuellos wrote:

> Phy part of the pci for this SoC can be handled using a generic phy
> driver. This commit extracts phy part of the mt7621-pci into a new
> 'mt7621-pci-phy' driver.
>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> ---
>  drivers/staging/Kconfig                       |   2 +
>  drivers/staging/Makefile                      |   1 +
>  drivers/staging/mt7621-pci-phy/Kconfig        |   7 +
>  drivers/staging/mt7621-pci-phy/Makefile       |   1 +
>  drivers/staging/mt7621-pci-phy/TODO           |   4 +
>  .../staging/mt7621-pci-phy/pci-mt7621-phy.c   | 411 ++++++++++++++++++
>  6 files changed, 426 insertions(+)
>  create mode 100644 drivers/staging/mt7621-pci-phy/Kconfig
>  create mode 100644 drivers/staging/mt7621-pci-phy/Makefile
>  create mode 100644 drivers/staging/mt7621-pci-phy/TODO
>  create mode 100644 drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
>
> diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
> index 7c015536360d..feec55e85347 100644
> --- a/drivers/staging/Kconfig
> +++ b/drivers/staging/Kconfig
> @@ -106,6 +106,8 @@ source "drivers/staging/pi433/Kconfig"
>  
>  source "drivers/staging/mt7621-pci/Kconfig"
>  
> +source "drivers/staging/mt7621-pci-phy/Kconfig"
> +
>  source "drivers/staging/mt7621-pinctrl/Kconfig"
>  
>  source "drivers/staging/mt7621-spi/Kconfig"
> diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> index a79b3fe20cf0..381891186572 100644
> --- a/drivers/staging/Makefile
> +++ b/drivers/staging/Makefile
> @@ -43,6 +43,7 @@ obj-$(CONFIG_BCM2835_VCHIQ)	+= vc04_services/
>  obj-$(CONFIG_DRM_VBOXVIDEO)	+= vboxvideo/
>  obj-$(CONFIG_PI433)		+= pi433/
>  obj-$(CONFIG_SOC_MT7621)	+= mt7621-pci/
> +obj-$(CONFIG_SOC_MT7621)	+= mt7621-pci-phy/
>  obj-$(CONFIG_SOC_MT7621)	+= mt7621-pinctrl/
>  obj-$(CONFIG_SOC_MT7621)	+= mt7621-spi/
>  obj-$(CONFIG_SOC_MT7621)	+= mt7621-dma/
> diff --git a/drivers/staging/mt7621-pci-phy/Kconfig b/drivers/staging/mt7621-pci-phy/Kconfig
> new file mode 100644
> index 000000000000..b9f6ab784ee8
> --- /dev/null
> +++ b/drivers/staging/mt7621-pci-phy/Kconfig
> @@ -0,0 +1,7 @@
> +config PCI_MT7621_PHY
> +	tristate "MediaTek MT7621 PCI PHY Driver"
> +	depends on RALINK && OF
> +	select GENERIC_PHY
> +	help
> +	  Say 'Y' here to add support for MediaTek MT7621 PCI PHY driver,
> +

I wonder if this should default to 'y' if SOC_MT7621 && PCI.

I cannot build if PCI_MT7621 is 'n' as pcibios_map_irq() is wanted but
not available.

I currently have the following patch, but maybe it should stay as
'tristate' - not sure.

Thanks,
NeilBrown

From: NeilBrown <neil@xxxxxxxxxx>
Date: Sun, 30 Dec 2018 20:00:57 +1100
Subject: [PATCH] staging: mt7621-pci: PCI driver is not optional when
 relevant.

The mt7621-pci driver must be enabled for SOC_MT7621 if PCI is
enabled, else a link failure results as pcibios_map_irq() is not
defined.

In any other circumstance, the driver is not relevant.
So make it non-selectable and provide an appropriate default.

Signed-off-by: NeilBrown <neil@xxxxxxxxxx>
---
 drivers/staging/mt7621-pci/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/mt7621-pci/Kconfig b/drivers/staging/mt7621-pci/Kconfig
index d33533872a16..2d64a4823055 100644
--- a/drivers/staging/mt7621-pci/Kconfig
+++ b/drivers/staging/mt7621-pci/Kconfig
@@ -1,6 +1,5 @@
 config PCI_MT7621
-	tristate "MediaTek MT7621 PCI Controller"
-	depends on RALINK
+	def_bool y if SOC_MT7621 && PCI
 	select PCI_DRIVERS_GENERIC
 	help
 	  This selects a driver for the MediaTek MT7621 PCI Controller.
-- 
2.14.0.rc0.dirty

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux