I'm not really complaining about breaking userspace, I'm complaining that I had to discover it by reading the code. It should have been mentioned in the commit message. We should probably just fold patch 1 & 6 together. I'm also not really complaining about this patch in particular when it comes to the API. The whole thing is a bit weird to me. I wish we could re-think the configuration from square one... It could be done in a later patch. I'm not going to NAK this patch if you resend it with the other small issues fixed. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
