On Mi, 2018-12-12 at 17:31 +0300, Dan Carpenter wrote: > On Wed, Dec 12, 2018 at 01:15:31PM +0100, Christian Gromm wrote: > > > > diff --git a/drivers/staging/most/Documentation/driver_usage.txt > > b/drivers/staging/most/Documentation/driver_usage.txt > > index bb9b4e8..da7a8f4 100644 > > --- a/drivers/staging/most/Documentation/driver_usage.txt > > +++ b/drivers/staging/most/Documentation/driver_usage.txt > > @@ -142,8 +142,9 @@ Cdev component example: > > > > Sound component example: > > > > -The sound component needs an additional parameter to determine the > > audio > > -resolution that is going to be used. The following formats are > > available: > > +The sound component needs additional parameters to determine the > > audio > > +resolution that is going to be used and to trigger the > > registration of a > > +sound card with ALSA. The following audio formats are available: > > > > - "1x8" (Mono) > > - "2x16" (16-bit stereo) > > @@ -151,9 +152,18 @@ resolution that is going to be used. The > > following formats are available: > > - "2x32" (32-bit stereo) > > - "6x16" (16-bit surround 5.1) > > > > - $ echo "mdev0:ep_81:sound:most51_playback.6x16" > > >$(DRV_DIR)/add_link > > +To make the sound module create a sound card and register it with > > ALSA the > > +string "create" needs to be attached to the module parameter > > section of the > > +configuration string. To create a sound card with with two > > playback devices > > +(linked to channel ep01 and ep02) and one capture device (linked > > to channel > > +ep83) the following is written to the add_link file: > > > > + $ echo "mdev0:ep01:sound:most51_playback.6x16" > > >$(DRV_DIR)/add_link > > + $ echo "mdev0:ep02:sound:most_playback.2x16" > > >$(DRV_DIR)/add_link > > + $ echo "mdev0:ep83:sound:most_capture.2x16.create" > > >$(DRV_DIR)/add_link > > > > +The link names (most51_playback, most_playback and most_capture) > > will > > +become the names of the PCM devices of the sound card. > So this patchset does break userspace... Which is allowed sometimes > in > staging, but it's better to point it out in the original commit which > causes the breakage. > The sound card layout that we have in mind is, from a system architecture point of view, the better one. Unfortunately, it does come with the cost of changing the configuration in one way or the other. Which is not really great, I agree on that. What I don't see is, why enhancing the way how user space interferes wi th the driver is such a terrible thing to do in staging. This should be the place to be to develop and change things (unless I totally misunderstood the concept behind it). > But really I don't like this API at all... It feels like something Fair enough. Is it just latest change that made you feel this way, or didn't you like the process in the first place? > from decades ago. There has to be a better way than this. > What if I would find a better way and change the API into something you like. Wouldn't that break user space too? Is this a dead end? How am I supposed to go on? > Unfortunately, I'm not clever enough to give you useful > suggestions... > thanks, Chris _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
