On Mon, Nov 19, 2018 at 6:09 AM Ardelean, Alexandru <alexandru.Ardelean@xxxxxxxxxx> wrote: > > On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > > This patch adds device tree support to ad2s90 with standard > > device tree id table. > > > > Hey, > > Comment inline > > > Signed-off-by: Matheus Tavares <matheus.bernardino@xxxxxx> > > --- > > Changes in v2: > > - none > > > > drivers/staging/iio/resolver/ad2s90.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/staging/iio/resolver/ad2s90.c > > b/drivers/staging/iio/resolver/ad2s90.c > > index 3e257ac46f7a..6ffbac66b837 100644 > > --- a/drivers/staging/iio/resolver/ad2s90.c > > +++ b/drivers/staging/iio/resolver/ad2s90.c > > @@ -107,6 +107,12 @@ static int ad2s90_probe(struct spi_device *spi) > > return devm_iio_device_register(indio_dev->dev.parent, indio_dev); > > } > > > > +static const struct of_device_id ad2s90_of_match[] = { > > + { .compatible = "adi,ad2s90", }, > > + {} > > +}; > > +MODULE_DEVICE_TABLE(of, ad2s90_of_match); > > + > > static const struct spi_device_id ad2s90_id[] = { > > { "ad2s90" }, > > {} > > @@ -116,6 +122,7 @@ MODULE_DEVICE_TABLE(spi, ad2s90_id); > > static struct spi_driver ad2s90_driver = { > > .driver = { > > .name = "ad2s90", > > + .of_match_table = of_match_ptr(ad2s90_of_match), > > I think you need to remove the of_match_ptr(). > There was a comment from Jonathan on another thread about this. > See: > https://patchwork.kernel.org/patch/10682963/ > Hm, got it, thanks! I don't understand much about ACPI yet, and I had understood the "of_match_ptr" as a guard. Could someone point me in which cases it should be used? Or is it obsolete? Matheus > So, > + .of_match_table = of_match_ptr(ad2s90_of_match), > > becomes > > + .of_match_table = ad2s90_of_match, > > > }, > > .probe = ad2s90_probe, > > .id_table = ad2s90_id, > > -- > You received this message because you are subscribed to the Google Groups "Kernel USP" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-usp+unsubscribe@xxxxxxxxxxxxxxxx. > To post to this group, send email to kernel-usp@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/kernel-usp/f250fa3a01b51d59979e7a2e3e42cc34d02aa52e.camel%40analog.com. > For more options, visit https://groups.google.com/d/optout. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel