Hi,
On 07-11-18 00:27, Josenivaldo Benito Jr wrote:
Correct following errors reported by checkpath.pl:
ERROR: space required before the open parenthesis '(' #265: FILE:
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c:265:
+ if(!precvframe) ')'
Also similar errors on line 274 and 283.
Signed-off-by: Josenivaldo Benito Jr <jrbenito@xxxxxxxxxxxxx>
---
I am new to the community, working on a study group called LKCamp.
Please provide any feedback to this patch so I can correct and learn.
Thanks
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
index 8507794..23d6cb6 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
@@ -262,7 +262,7 @@ static void rtl8723bs_recv_tasklet(void *priv)
while (ptr < precvbuf->ptail) {
precvframe = try_alloc_recvframe(precvpriv, precvbuf);
- if(!precvframe)
+ if (!precvframe)
return;
/* rx desc parsing */
@@ -271,7 +271,7 @@ static void rtl8723bs_recv_tasklet(void *priv)
pattrib = &precvframe->u.hdr.attrib;
- if(rx_crc_err(precvpriv, p_hal_data,
+ if (rx_crc_err(precvpriv, p_hal_data,
pattrib, precvframe))
The rx_crc_err call is split over 2 lines here. Since you added a space
in the first line of the call you also need to add a space in front
of the pattrib, so that the p is below the first letter of the first
argument of the function call (and not below the '(' ).
So after the fix this should look like this:
if (rx_crc_err(precvpriv, p_hal_data,
pattrib, precvframe))
Note this will only look good if your email client shows tabs correctly
and you are using a fixed-width font.
break;
@@ -280,7 +280,7 @@ static void rtl8723bs_recv_tasklet(void *priv)
pattrib->shift_sz +
pattrib->pkt_len;
- if(pkt_exceeds_tail(precvpriv, ptr + pkt_offset,
+ if (pkt_exceeds_tail(precvpriv, ptr + pkt_offset,
precvbuf->ptail, precvframe))
break;
Same here.
Otherwise this looks good to me.
Regards,
Hans
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
