Re: [PATCH v3] staging: dgnc: Fix Kconfig help header and text

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/1/18 12:49 PM, Lidza Louina wrote:
On Mon, Oct 1, 2018 at 8:09 AM Mark Hounschell <markh@xxxxxxxxxx <mailto:markh@xxxxxxxxxx>> wrote:

    On 9/28/18 3:59 PM, Lidza Louina wrote:
     > I haven't done work on this driver in a long time. I looked up the
     > devices, and they seem to already have an existing Linux driver:
     >
    https://www.digi.com/products/usb-and-serial-connectivity/serial-cards/digineo and

     > https://www.digi.com/support/productdetail?pid=1694
     >
     > I've contacted the company to see if the driver is still needed in
     > staging. I'll send an update once they get back to me.
     >
     > Lidza
     >

    Good luck with that. Digi obsoleted ALL their PCI serial cards several
    months ago. They would not even respond to requests from me to include
    their firmware for their PCI dgap cards into the kernel firmware
    package. The card for the dgnc driver is a pci-e card that may still be
    supported by them however. Also there does appear to be an already in
    kernel driver for these "PCI-e" cards too. It actually works as I
    have a
    couple of these cards. The module name is "jsm".


    03:00.0 Serial controller: Digi International Device 00f0 (rev 02)
    (prog-if 02 [16550])
              Subsystem: Digi International Device 00f0
              Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
    ParErr- Stepping- SERR- FastB2B- DisINTx-
              Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=fast
     >TAbort-
    <TAbort- <MAbort- >SERR- <PERR- INTx-
              Interrupt: pin A routed to IRQ 29
              Region 0: Memory at f7200000 (32-bit, non-prefetchable)
    [size=4K]
              Capabilities: [40] Power Management version 2
                      Flags: PMEClk+ DSI- D1- D2- AuxCurrent=0mA
    PME(D0-,D1-,D2-,D3hot+,D3cold-)
                      Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
              Kernel driver in use: jsm
              Kernel modules: jsm


    Regards
    Mark


Thanks for the heads up Mark. I've totally neglected this driver and should have caught this earlier. I'm okay with removing it from staging. We can bring it back if they need it.


It may actually be my fault that Greg-KH added the dgnc driver to staging. Shortly after Digi stopped supporting their PCI cards, I had some contact with Greg-KH and sent him all the Digi GPL drivers that I was using at the time for possible inclusion. Digi was no longer maintaining them. I did not know at the time about the jsm driver already being there.

The dgnc driver supports the following PCI cards:
#define PCI_DEVICE_CLASSIC_4_DID                0x0028
#define PCI_DEVICE_CLASSIC_8_DID                0x0029
#define PCI_DEVICE_CLASSIC_4_422_DID            0x00D0
#define PCI_DEVICE_CLASSIC_8_422_DID            0x00D1

The jsm driver supports all of these plus their newer PCI-e cards:
#define PCI_DEVICE_ID_CLASSIC_4         0x0028
#define PCI_DEVICE_ID_CLASSIC_8         0x0029
#define PCI_DEVICE_ID_CLASSIC_4_422     0x00D0
#define PCI_DEVICE_ID_CLASSIC_8_422     0x00D1

#define PCI_DEVICE_ID_NEO_4             0x00B0
#define PCI_DEVICE_ID_NEO_1_422         0x00CC
#define PCI_DEVICE_ID_NEO_1_422_485     0x00CD
#define PCI_DEVICE_ID_NEO_2_422_485     0x00CE
#define PCIE_DEVICE_ID_NEO_8            0x00F0
#define PCIE_DEVICE_ID_NEO_4            0x00F1
#define PCIE_DEVICE_ID_NEO_4RJ45        0x00F2
#define PCIE_DEVICE_ID_NEO_8RJ45        0x00F3

So I think it is safe to remove the dgnc driver from staging. I also think the PCI-e versions defined above are actually still available from Digi as current products.

Regards
Mark
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux