Re: [PATCH] staging: dgnc: Fix Kconfig help header and text

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/25/18 11:46 AM, Greg Kroah-Hartman wrote:
> On Tue, Sep 25, 2018 at 10:22:24AM -0600, sehro rautenkranz wrote:
>> Replace Kconfig help header and text to match other modules. Issue found
>> my checkpatch.
>>
>> Spacing adjusted to match Documentation/process/coding-style.rst. Issue
>> reported by rdunlap@xxxxxxxxxxxxx. (try 2)
> 
> The "try 2" needs go to below the --- line.
> 
> Also, you need to properly version your patches so that I have a clue
> as to which is the "latest" one.
> 
>> Signed-off-by: sehro rautenkranz <sehro@xxxxxxxxx>
> 
> You forgot Randy's Reported-by.
> 
> Also, properly Capitalize your name.
> 
> v3?

and the help text is still not indented correctly:
use one tab + 2 spaces for help text.

-- 
~Randy
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux