Re: [PATCH v3 00/29] staging: wilc1000: avoid static variables and cleanup changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dan,

On Mon, 1 Oct 2018 10:47:34 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> On Tue, Sep 25, 2018 at 11:53:15AM +0530, Ajay Singh wrote:
> > This patch series contains changes to avoid the use of static
> > variables. Cleanup changes to fix some checkpatch issues and return
> > void for function if their return value is not used.
> > Also deleted 'wilc_debugfs.c' file as it's not used.
> > 
> > Changes since v2:
> >    Included Joe's suggestion for patch#28
> >     - replaced previous patch with an improved version(refactor
> > code)
> > 
> > Changes since v1:
> >    Address Dan's comment for patch#29
> >     - return the correct error for failure in the second iteration  
> 
> Btw, I hate re-reviewing patches and I know everyone hates sending
> them. If someone complains about a 28/29 or a 29/29, then you can
> just ask Greg to apply the first 27 and redo the others in a follow
> on patchset.
> 
Sure, I will keep this point in mind while sending the series updates.

Regards
Ajay

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux