On Fri 28-09-18 17:03:57, David Hildenbrand wrote: [...] I haven't read the patch itself but I just wanted to note one thing about this part > For paravirtualized devices it is relevant that memory is onlined as > quickly as possible after adding - and that it is added to the NORMAL > zone. Otherwise, it could happen that too much memory in a row is added > (but not onlined), resulting in out-of-memory conditions due to the > additional memory for "struct pages" and friends. MOVABLE zone as well > as delays might be very problematic and lead to crashes (e.g. zone > imbalance). I have proposed (but haven't finished this due to other stuff) a solution for this. Newly added memory can host memmaps itself and then you do not have the problem in the first place. For vmemmap it would have an advantage that you do not really have to beg for 2MB pages to back the whole section but you would get it for free because the initial part of the section is by definition properly aligned and unused. I yet have to think about the whole proposal but I am missing the most important part. _Who_ is going to use the new exported information and for what purpose. You said that distributions have hard time to distinguish different types of onlinining policies but isn't this something that is inherently usecase specific? -- Michal Hocko SUSE Labs _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
