Hi all, Sent out the v2. Please help to review. Thanks a lot. Hi Andrew, > -----Original Message----- > From: Y.b. Lu > Sent: Friday, September 28, 2018 4:04 PM > To: 'Andrew Lunn' <andrew@xxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; Richard Cochran <richardcochran@xxxxxxxxx>; > David S . Miller <davem@xxxxxxxxxxxxx>; Ioana Ciocoi Radulescu > <ruxandra.radulescu@xxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> > Subject: RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/ > > Hi Andrew, > > Thanks a lot for your comments. > Please see my comments inline. > > Best regards, > Yangbo Lu > > > -----Original Message----- > > From: Andrew Lunn <andrew@xxxxxxx> > > Sent: Thursday, September 27, 2018 9:25 PM > > To: Y.b. Lu <yangbo.lu@xxxxxxx> > > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx; > > netdev@xxxxxxxxxxxxxxx; Richard Cochran <richardcochran@xxxxxxxxx>; > > David S . Miller <davem@xxxxxxxxxxxxx>; Ioana Ciocoi Radulescu > > <ruxandra.radulescu@xxxxxxx>; Greg Kroah-Hartman > > <gregkh@xxxxxxxxxxxxxxxxxxx> > > Subject: Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of > > staging/ > > > > On Thu, Sep 27, 2018 at 07:12:27PM +0800, Yangbo Lu wrote: > > > This patch is to move DPAA2 PTP driver out of staging/ since the > > > dpaa2-eth had been moved out. > > > > > > Signed-off-by: Yangbo Lu <yangbo.lu@xxxxxxx> > > > --- [...] > > > Can rtc_drv be made const? > > [Y.b. Lu] Will use const in next version. > [Y.b. Lu] Sorry, just found it couldn't be made const. Warnings showed when built with const. > > Is rtc.h used by anything other than rtc.c? It seems like it can be removed. > > [Y.b. Lu] Let me remove it in next version. [Y.b. Lu] Sorry, I still kept that header file since dpaa2_phc_index need to be declared. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
