Hi Andrew, > -----Original Message----- > From: Andrew Lunn <andrew@xxxxxxx> > Sent: Friday, September 28, 2018 11:18 PM > To: Y.b. Lu <yangbo.lu@xxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; Richard Cochran <richardcochran@xxxxxxxxx>; > David S . Miller <davem@xxxxxxxxxxxxx>; Ioana Ciocoi Radulescu > <ruxandra.radulescu@xxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> > Subject: Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/ > > > > struct dprtc_cmd_get_irq - Putting pad at the beginning of a struct > > > seems very odd. And it is not the only example. > > > > [Y.b. Lu] This should depended on MC firmware and APIs I think. Once the > MC improves this, the APIs could be updated to fix this. > > That is going to be hard to do. Ideally the driver should work with any > firmware version. You don't really want to force the user to upgrade the > driver/kernel and the firmware at the same time. So you cannot for example > remove this pad. What you might be able to do in newer versions is actually > use the space. But you have to be sure the current code is correctly ignoring it > and setting it to zero. [Y.b. Lu] Thanks a lot, I think I understand now😊 The files dprtc* defining the APIs were provided together with MC firmware. They were tested working fine. MC firmware would also consider the backward compatibility I think. Regarding to the API files, let me remove unused code before using them, and keep the rest. > > Andrew _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
