[PATCH v2 00/62] staging: wlan-ng: coding style changes/cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Switch to all-upper or all-lower (for function-style) case names for
macros in p80211metadef.h to silence checkpatch messages and match the
coding guidelines. Shorten names that have repeated elements. Rejoin
lines split to keep within 80 characters that now fit due to shortened
names.

Make the use of braced blocks in switch cases consistent across the
driver by always using K&R style, braces at the case level and a
single indent. Rejoin split lines that now fit within 80 characters
due to reduced indentation.

Cleanup unneeded braces on a single line if statement.

Remove the comments stating that p80211metadef.h and
p80211metastruct.h are automatically generated and should not be
edited; neither file has a mechanism for generation and both have been
manually edited and updated in version control multiple times.

Patches should be applied in order as there are some dependencies.

Changes since v1:

    - drop removal of redundant code commented out with #if 0 (already
      applied)

    - split renaming changes for macros in p80211metadef.h into one
      patch per identifier, as suggested by GregKH, and to make all
      changes to each name in 1 step, as suggested by Dan Carpenter

Tim Collier (62):
  staging: wlan-ng: rename DIDmsg_dot11req_mibget in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_dot11req_mibget_mibattribute in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_dot11req_mibget_resultcode in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_dot11req_mibset in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_dot11req_mibset_mibattribute in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_dot11req_mibset_resultcode in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_dot11req_scan in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_dot11req_scan_results in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_dot11req_start in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_dot11ind_authenticate in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_lnxreq_ifstate in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_lnxreq_wlansniff in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_lnxreq_hostwep in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_lnxreq_commsquality in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_lnxreq_autojoin in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_readpda in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_readpda_pda in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_dot11ind_associate in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_readpda_resultcode in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_ramdl_state in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_ramdl_state_enable in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_ramdl_state_exeaddr in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_ramdl_state_resultcode in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_ramdl_write in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_addr in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_len in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_data in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_resultcode in
    p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_flashdl_state in p80211metadef.h
  staging: wlan-ng: rename DIDmsg_p2req_flashdl_write in p80211metadef.h
  staging: wlan-ng: rename DIDmib_cat_dot11smt in p80211metadef.h
  staging: wlan-ng: rename DIDmib_dot11smt_dot11WEPDefaultKeysTable in
    p80211metadef.h
  staging: wlan-ng: rename DIDmib_dot11smt_dot11WEPDefaultKeysTable_key
    in p80211metadef.h
  staging: wlan-ng: rename DIDmib_dot11smt_dot11PrivacyTable in
    p80211metadef.h
  staging: wlan-ng: rename
    DIDmib_dot11smt_dot11PrivacyTable_dot11PrivacyInvoked in
    p80211metadef.h
  staging: wlan-ng: rename
    DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID in
    p80211metadef.h
  staging: wlan-ng: rename
    DIDmib_dot11smt_dot11PrivacyTable_dot11ExcludeUnencrypted in
    p80211metadef.h
  staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable in
    p80211metadef.h
  staging: wlan-ng: rename
    DIDmib_dot11mac_dot11OperationTable_dot11MACAddress in
    p80211metadef.h
  staging: wlan-ng:
    DIDmib_dot11mac_dot11OperationTable_dot11RTSThreshold in
    p80211metadef.h
  staging: wlan-ng: rename
    DIDmib_dot11mac_dot11OperationTable_dot11ShortRetryLimit in
    p80211metadef.h
  staging: wlan-ng: rename
    DIDmib_dot11mac_dot11OperationTable_dot11LongRetryLimit in
    p80211metadef.h
  staging: wlan-ng: rename
    DIDmib_dot11mac_dot11OperationTable_dot11FragmentationThreshold in
    p80211metadef.h
  staging: wlan-ng: rename
    DIDmib_dot11mac_dot11OperationTable_dot11MaxTransmitMSDULifetime in
    p80211metadef.h
  staging: wlan-ng: rename DIDmib_cat_dot11phy in p80211metadef.h
  staging: wlan-ng: rename DIDmib_dot11phy_dot11PhyOperationTable in
    p80211metadef.h
  staging: wlan-ng: rename
    DIDmib_dot11phy_dot11PhyTxPowerTable_dot11CurrentTxPowerLevel in
    p80211metadef.h
  staging: wlan-ng: rename DIDmib_dot11phy_dot11PhyDSSSTable in
    p80211metadef.h
  staging: wlan-ng: rename
    DIDmib_dot11phy_dot11PhyDSSSTable_dot11CurrentChannel in
    p80211metadef.h
  staging: wlan-ng: rename DIDmib_cat_lnx in p80211metadef.h
  staging: wlan-ng: rename DIDmib_lnx_lnxConfigTable in p80211metadef.h
  staging: wlan-ng: rename DIDmib_lnx_lnxConfigTable_lnxRSNAIE in
    p80211metadef.h
  staging: wlan-ng: rename DIDmib_cat_p2 in p80211metadef.h
  staging: wlan-ng: rename DIDmib_p2_p2Static in p80211metadef.h
  staging: wlan-ng: rename DIDmib_p2_p2Static_p2CnfPortType in
    p80211metadef.h
  staging: wlan-ng: rename DIDmib_p2_p2NIC_p2PRISupRange in
    p80211metadef.h
  staging: wlan-ng: rename DIDmib_p2_p2MAC in p80211metadef.h
  staging: wlan-ng: rename DIDmib_p2_p2MAC_p2CurrentTxRate in
    p80211metadef.h
  staging: wlan-ng: formatting cleanup in cfg80211.c
  staging: wlan-ng: make switch case block format consistent
  staging: wlan-ng: rejoin split lines shortened by case changes
  staging: wlan-ng: remove "autogenerated code" comments

 drivers/staging/wlan-ng/cfg80211.c         |  49 ++++++------
 drivers/staging/wlan-ng/hfa384x_usb.c      |  46 +++++------
 drivers/staging/wlan-ng/p80211metadef.h    | 121 ++++++++++++++---------------
 drivers/staging/wlan-ng/p80211metastruct.h |   3 +-
 drivers/staging/wlan-ng/p80211netdev.c     |   8 +-
 drivers/staging/wlan-ng/p80211req.c        |  36 ++++-----
 drivers/staging/wlan-ng/prism2fw.c         |  32 ++++----
 drivers/staging/wlan-ng/prism2mib.c        |  76 +++++++++---------
 drivers/staging/wlan-ng/prism2sta.c        |  86 ++++++++++----------
 9 files changed, 222 insertions(+), 235 deletions(-)

-- 
2.11.0

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux