On Tue, Mar 01, 2011 at 11:00:06PM +0300, Dan Carpenter wrote: > On Tue, Mar 01, 2011 at 08:29:50PM +0100, Roel Van Nyen wrote: > > Remove all type defines from driver and replace them with kernel built-in types. > > > > Signed-off-by: Roel Van Nyen <roel.vannyen@xxxxxxxxx> > > Some of your other patches were merged so this doesn't apply to > linux-next any more. Indeed, I should have made a patch-set instead. > > > -typedef u8 BOOLEAN; > > It might be better to use bool type or int for boolean variables. But > that can't be done automatically, it has to be audited carefully. I > don't feel strongly about this, I'm just throwing it out there as food > for thought. You are using the remove-typedef program btw? I did not use the remove-typedef program, I used perl regex. (btw: where is that, i could not find it) I will post a patchset later tonight wich contains the removal of all the types from this driver. The first patch will contain the removal of all types except the BOOLEAN. In the second one I will remove the boolean and check where to make it an integer and where a bool. thanks, roel _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
