On Tue, Mar 01, 2011 at 08:29:50PM +0100, Roel Van Nyen wrote: > Remove all type defines from driver and replace them with kernel built-in types. > > Signed-off-by: Roel Van Nyen <roel.vannyen@xxxxxxxxx> Some of your other patches were merged so this doesn't apply to linux-next any more. > -typedef u8 BOOLEAN; It might be better to use bool type or int for boolean variables. But that can't be done automatically, it has to be audited carefully. I don't feel strongly about this, I'm just throwing it out there as food for thought. You are using the remove-typedef program btw? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel