Re: [PATCH v10 00/15] staging: mt7621-pci: avoid custom pci config read and writes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 8, 2018 at 2:08 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Aug 06, 2018 at 10:21:46AM +1000, NeilBrown wrote:
>> On Fri, Aug 03 2018, Sergio Paracuellos wrote:
>>
>> > This patch series include an attempt to avoid the use of custom
>> > read and writes in driver code and use PCI subsystem common ones.
>> >
>> > In order to do this 'map_bus' callback is implemented and also
>> > data structures for driver are included. The regs base address
>> > ranges and data is being readed from device tree and the driver
>> > gets clean a lot of code.
>> >
>> > This patchet also removes all legacy PCI code using now PCI_DRIVERS_GENERIC
>> > kernel api.
>> >
>> > Changes in v10:
>> >     - PATCH 1: Do 'ioremap' directly using 'ranges.cpu_addr' from the
>> >       io resource and add it directly as a resource to the resources list
>> >       like mips pci-legacy code do for this. We cannot do anything else since
>> >       using new kernel pci generic apis (call to 'devm_of_pci_get_host_bridge_resources')
>> >       we get bad io resource getting 'OF_BAD_ADDR' because of the fact that the
>> >       io resource for this platform starts in  0x1e160000 which is higher than
>> >       IO_SPACE_LIMIT (0xFFFF). Because of this io resource is not added to the resources
>> >       list and system gets into a not working state.
>> >     - Other patches rebased and adapted to this changes.
>>
>> And...... we have a winner !!!
>>
>> Tested-by: NeilBrown <neil@xxxxxxxxxx>
>>
>> I haven't actually looked at the code - just compiled, booted, saw that
>> the SATA drive appears to work.
>
> Yeah!!!  Sergio, nice job.

Thanks, Greg. Is good to see all of this added to the tree :-). New
cleanups comming soon!

>
> greg k-h

Best regards,
    Sergio Paracuellos
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux