Re: [PATCH] Staging: fbtft: fbtft-sysfs: fixed a 80 char line coding style issue Staging: fbtft: flexfb: fixed a 80 char line coding style issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 28, 2018 at 10:08:28PM +0400, sepehrdad.dev@xxxxxxxxx wrote:
> From: sepehrdad sh <sepehrdad.dev@xxxxxxxxx>
> 
> Fixed multiple coding style issue
> 
> Signed-off-by: Sepehrdad Sh <sepehrdad.dev@xxxxxxxxx>


Your subject line is very odd :(

> --- a/drivers/staging/fbtft/flexfb.c
> +++ b/drivers/staging/fbtft/flexfb.c
> @@ -667,11 +667,14 @@ static int flexfb_probe_common(struct spi_device *sdev,
>  		case 8:
>  			par->fbtftops.write_vmem = fbtft_write_vmem16_bus8;
>  			if (!par->startbyte)
> -				par->fbtftops.verify_gpios = flexfb_verify_gpios_dc;
> +				par->fbtftops.verify_gpios = (
> +				flexfb_verify_gpios_dc);

That's a very strange change.  Do you know C well?  Because this is not
how you do such a modification :(

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux