Re: [RFC PATCH v3] Xilinx AXI-Stream FIFO v4.1 IP core driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 19, 2018 at 09:45:31PM -0400, Jacob Feder wrote:
> First I run "make menuconfig" and select my driver in "device drivers" >
> "staging". If I run "make" or "make all" or
> "make drivers/staging/axis-fifo" everything compiles without errors or 
> warnings even if I put blatant syntax errors in my code.
> What am I missing here?

You have to modify drivers/staging/Makefile and drivers/staging/Kconfig
to add your driver to the build so it will work properly if you do
'make' and not give a specific subdirectory.

As an example, look at the diffstat when the vboxvideo driver was added
to the tree.  It is commit dd55d44f4084 ("staging: vboxvideo: Add
vboxvideo to drivers/staging"):
	$ git show dd55d44f4084 | diffstat -p1
	 drivers/staging/Kconfig                     |    2
	 drivers/staging/Makefile                    |    1
	 drivers/staging/vboxvideo/Kconfig           |   12
	 drivers/staging/vboxvideo/Makefile          |    7
	 drivers/staging/vboxvideo/TODO              |    9
	 drivers/staging/vboxvideo/hgsmi_base.c      |  246 +++++++
	 drivers/staging/vboxvideo/hgsmi_ch_setup.h  |   66 ++
	 drivers/staging/vboxvideo/hgsmi_channels.h  |   53 +
	 drivers/staging/vboxvideo/hgsmi_defs.h      |   92 ++
	 drivers/staging/vboxvideo/modesetting.c     |  142 ++++
	 drivers/staging/vboxvideo/vbox_drv.c        |  286 +++++++++
	 drivers/staging/vboxvideo/vbox_drv.h        |  296 +++++++++
	 drivers/staging/vboxvideo/vbox_err.h        |   50 +
	 drivers/staging/vboxvideo/vbox_fb.c         |  412 +++++++++++++
	 drivers/staging/vboxvideo/vbox_hgsmi.c      |  115 +++
	 drivers/staging/vboxvideo/vbox_irq.c        |  197 ++++++
	 drivers/staging/vboxvideo/vbox_main.c       |  534 +++++++++++++++++
	 drivers/staging/vboxvideo/vbox_mode.c       |  877 ++++++++++++++++++++++++++++
	 drivers/staging/vboxvideo/vbox_prime.c      |   74 ++
	 drivers/staging/vboxvideo/vbox_ttm.c        |  472 +++++++++++++++
	 drivers/staging/vboxvideo/vboxvideo.h       |  491 +++++++++++++++
	 drivers/staging/vboxvideo/vboxvideo_guest.h |   95 +++
	 drivers/staging/vboxvideo/vboxvideo_vbe.h   |   84 ++
	 drivers/staging/vboxvideo/vbva_base.c       |  233 +++++++
	 24 files changed, 4846 insertions(+)

In it the main drivers/staging Makefile and Kconfig files have a line
added to add the subdirectory to the build process.

Try copying that logic for your patch when you resend it.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux