Re: [PATCH v2 2/2] staging: gasket: Use __func__ instead of hardcoded string - Style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 13, 2018 at 12:58:49AM +0200, Felix Siegel wrote:
> Changed logging statements to use %s and __func__ instead of hard coding
> the function name in a string.
> 
> Signed-off-by: Felix Siegel <felix.siegel@xxxxxxxxx>
> ---
>  drivers/staging/gasket/apex_driver.c       |  7 ++++---
>  drivers/staging/gasket/gasket_core.c       |  8 +++++---
>  drivers/staging/gasket/gasket_ioctl.c      |  3 ++-
>  drivers/staging/gasket/gasket_page_table.c | 13 ++++++++-----
>  4 files changed, 19 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
> index 9218ad7..ee91137 100644
> --- a/drivers/staging/gasket/apex_driver.c
> +++ b/drivers/staging/gasket/apex_driver.c
> @@ -427,8 +427,9 @@ static int apex_device_cleanup(struct gasket_dev *gasket_dev)
>  
>  	gasket_log_info(
>  		gasket_dev,
> -		"apex_device_cleanup 0x%p hib_error 0x%llx scalar_error "
> +		"%s 0x%p hib_error 0x%llx scalar_error "
>  		"0x%llx.",

One nit, it's not your doing, but the string should be all on one line
here.  Something to think about for future patches :)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux