Re: [PATCH 4/4] staging: gasket: Use __func__ instead of hardcoded string - Style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 13, 2018 at 12:58:47AM +0200, Felix Siegel wrote:
> > Function calls that do nothing but log "Look at this function I just
> > entered/exited!" need to just be deleted entirely, as ftrace should be
> > used instead.
> > 
> > Care to do that here, and then send a patch for the remaining messages
> > that do need __func__?
> Sure. I hope this is how you meant it.
> I kept the calls that print more than just the name of the function.

Looks great, thanks, I'll go queue them up.

You can also now work on converting those macros to the "normal" kernel
logging macros if you want (dev_*()) as no single driver/subsystem
should have their own set of logging macros.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux