This patch series clean up a bit mt7621-pci driver. Chnages in v3: - PATCH 1 has been splited in several patches for better review - PATCH "avoid pointer arithmetics in some macros" gets back a needed switch statement as it has been pointed out here: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-July/122872.html Changes in v2: - It includes new 17 patches from PATCH 2 to PATCH 18 - PATCH 1 was send before alone and is being included as it is in this new series. Hope this helps. Best regards, Sergio Paracuellos Sergio Paracuellos (23): staging: mt7621-pci: remove unused macro MV_READ_DATA staging: mt7621-pci: factor out mt7621_pci_get_cfgaddr function staging: mt7621-pci: add new variable to be set to PCI base address staging: mt7621-pci: reimplement pci_config_[read|write] functions staging: mt7621-pci: remove no more needed helper functions and macros staging: mt7621-pci: avoid long lines in read_config and write_config functions staging: mt7621-pci: use writel and readl instead of custom macros staging: mt7621-pci: remove no more needed macros staging: mt7621-pci: simplify pci dependant registers arithmetics staging: mt7621-pci: avoid pointer arithmetics in some macros staging: mt7621-pci: use BIT macro in definitions staging: mt7621-pci: use read and writes in set_pcie_phy function staging: mt7621-pci: make ASSERT_SYSRST_PCIE and DEASSERT_SYSRST_PCIE inline functions staging: mt7621-pci: rewrite [read|write]_config functions staging: mt7621-pci: factor out mt7621_pci_enable_irqs and mt7621_pci_disable staging: mt7621-pci: minor refactor in duplicated code staging: mt7621-pci: factor out mt7621_pci_enable function staging: mt7621-pci: factor out mt7621_pci_configure function staging: mt7621-pci: add blank line between declarations and code statements staging: mt7621-pci: remove unused preprocessor defines staging: mt7621-pci: rename RALINK_PCI_CONFIG_DATA_VIRTUAL_REG definition staging: mt7621-pci: fix and remove some comments staging: mt7621-pci: factor out mt7621_pci_init_gpios function drivers/staging/mt7621-pci/pci-mt7621.c | 676 +++++++++++++++----------------- 1 file changed, 311 insertions(+), 365 deletions(-) -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel