On Sun, Jul 08, 2018 at 04:06:08PM +0200, Sergio Paracuellos wrote: > On Sun, Jul 8, 2018 at 3:16 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Sun, Jul 08, 2018 at 02:57:26PM +0200, Sergio Paracuellos wrote: > >> It's good to have SPDX identifiers in driver files to make it easier to > >> audit the kernel tree for correct licenses. > >> > >> Fix up the one of staging pci-mt7621.c file to have a proper SPDX > >> identifier, based on the license text in the file itself. The SPDX > >> identifier is a legally binding shorthand, which can be used instead of > >> the full boiler plate text. > >> > >> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> > >> --- > >> drivers/staging/mt7621-pci/pci-mt7621.c | 28 ++-------------------------- > >> 1 file changed, 2 insertions(+), 26 deletions(-) > >> > >> diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c > >> index b4e049a..d92df91 100644 > >> --- a/drivers/staging/mt7621-pci/pci-mt7621.c > >> +++ b/drivers/staging/mt7621-pci/pci-mt7621.c > >> @@ -1,32 +1,10 @@ > >> -/************************************************************************** > >> - * > >> +// SPDX-License-Identifier: GPL-2.0 > > > > Ok, but: > > > >> - * This program is free software; you can redistribute it and/or modify it > >> - * under the terms of the GNU General Public License as published by the > >> - * Free Software Foundation; either version 2 of the License, or (at your > >> - * option) any later version. > > > > You used the wrong license for the SPDX line :( > > > > PLEASE be careful about this, it matters as it is a legal thing you are > > dealing with. > > I see. Sorry I misunderstood the "any later version" part. So I > suppose the correct line should be GPL-2.0+. Don't "suppose" when dealing with legal issues. Please leave these types of changes to the type of people who know licenses and the issues surrounding them. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
